projects/linux·commit d359b549

[PATCH] futex_find_get_task(): don't take tasklist_lock

d359b549 · Oleg Nesterov <[email protected]> · 2006-09-29 02:00:55 -07:00

It is ok to do find_task_by_pid() + get_task_struct() under
rcu_read_lock(), we cand drop tasklist_lock.

Note that testing of ->exit_state is racy with or without tasklist anyway.

Signed-off-by: Oleg Nesterov <[email protected]>
Acked-by: Ingo Molnar <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
d359b549bf3d7f42f0084918a4816ea4572e507c
Parents
44938af6

Changes

1 files changed · +2 −2

FileStatusAddDelContent
kernel/futex.cmodified+2−2View file

kernel/futex.c

View file
diff --git a/kernel/futex.c b/kernel/futex.c
index 9d260e8..ca8ef11 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -389,7 +389,7 @@ static struct task_struct * futex_find_get_task(pid_t pid)
{
struct task_struct *p;
- read_lock(&tasklist_lock);
+ rcu_read_lock();
p = find_task_by_pid(pid);
if (!p)
goto out_unlock;
@@ -403,7 +403,7 @@ static struct task_struct * futex_find_get_task(pid_t pid)
}
get_task_struct(p);
out_unlock:
- read_unlock(&tasklist_lock);
+ rcu_read_unlock();
return p;
}