fix logic error in ipc compat semctl()

d57d9731 · Alexander Graf <[email protected]> · 2007-07-06 02:39:53 -07:00

When calling a semctl(IPC_STAT) without IPC_64 the check if the memory is
unevaluated.  This patch fixes this.

Signed-off-by: Alexander Graf <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: d57d973101e87b2e30ccfa899fe36c4b2e32d217
Parents: 0db19c41

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
ipc/compat.c	modified	+1	−1	View file

ipc/compat.c

View file

diff --git a/ipc/compat.c b/ipc/compat.c
index 8b44aa9..ab76fb0 100644
--- a/ipc/compat.c
+++ b/ipc/compat.c
@@ -225,7 +225,7 @@ static inline int put_compat_semid_ds(struct semid64_ds *s,
 	int err;
 
 	if (!access_ok (VERIFY_WRITE, up, sizeof(*up)))
-		err = -EFAULT;
+		return -EFAULT;
 	err  = __put_compat_ipc_perm(&s->sem_perm, &up->sem_perm);
 	err |= __put_user(s->sem_otime, &up->sem_otime);
 	err |= __put_user(s->sem_ctime, &up->sem_ctime);