i2o: fix overflow of copy_to_user()

d929dc2b · Kulikov Vasiliy <[email protected]> · 2010-08-10 18:02:03 -07:00

If (len > reslen) we must not call copy_to_user() since kernel buffer is
smaller than we want to copy.  Similar code in this file is correct, so
this bug was a typo.

Signed-off-by: Kulikov Vasiliy <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: d929dc2bfd8a58c34f1df0680018fa8ea5caa907
Parents: 32fa4549

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/message/i2o/i2o_config.c	modified	+1	−1	View file

drivers/message/i2o/i2o_config.c

View file

diff --git a/drivers/message/i2o/i2o_config.c b/drivers/message/i2o/i2o_config.c
index c4b117f..4dd39a0 100644
--- a/drivers/message/i2o/i2o_config.c
+++ b/drivers/message/i2o/i2o_config.c
@@ -115,7 +115,7 @@ static int i2o_cfg_gethrt(unsigned long arg)
 	put_user(len, kcmd.reslen);
 	if (len > reslen)
 		ret = -ENOBUFS;
-	if (copy_to_user(kcmd.resbuf, (void *)hrt, len))
+	else if (copy_to_user(kcmd.resbuf, (void *)hrt, len))
 		ret = -EFAULT;
 
 	return ret;