vfio/platform: fix module_put call in error flow

dc51ff91 · Max Gurtovoy <[email protected]> · 2021-05-18 22:21:31 +03:00

The ->parent_module is the one that use in try_module_get. It should
also be the one the we use in module_put during vfio_platform_open().

Fixes: 32a2d71c4e80 ("vfio: platform: introduce vfio-platform-base module")
Signed-off-by: Max Gurtovoy <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Alex Williamson <[email protected]>

Commit: dc51ff91cf2d1e9a2d941da483602f71d4a51472
Parents: 752774ce

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/vfio/platform/vfio_platform_common.c	modified	+1	−1	View file

drivers/vfio/platform/vfio_platform_common.c

View file

diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index 361e5b5..470fcf7 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -291,7 +291,7 @@ err_irq:
 	vfio_platform_regions_cleanup(vdev);
 err_reg:
 	mutex_unlock(&driver_lock);
-	module_put(THIS_MODULE);
+	module_put(vdev->parent_module);
 	return ret;
 }
 