atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found

dfecb716 · Hans-Christian Egtvedt <[email protected]> · 2009-02-04 15:12:17 -08:00

The ssc pointer is not valid when the id is not found in the list.
Convert the message from a debug one into an error message and avoid
dereferencing the bad pointer.

Signed-off-by: Hans-Christian Egtvedt <[email protected]>
Cc: Kay Sievers <[email protected]>
Cc: Huang Weiyi <[email protected]>
Acked-by: Haavard Skinnemoen <[email protected]>
Cc: David Brownell <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit: dfecb7164eb81fbfae93fee1ad1da2ac58bb224d
Parents: ab92661d

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/misc/atmel-ssc.c	modified	+1	−1	View file

drivers/misc/atmel-ssc.c

View file

diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index bf5e4d0..558bf3f 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -35,7 +35,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num)
 
 	if (!ssc_valid) {
 		spin_unlock(&user_lock);
-		dev_dbg(&ssc->pdev->dev, "could not find requested device\n");
+		pr_err("ssc: ssc%d platform device is missing\n", ssc_num);
 		return ERR_PTR(-ENODEV);
 	}
 