gpio: bcm281xx: Fix return value of bcm_kona_gpio_get()

e2f0b005 · Markus Mayer <[email protected]> · 2013-11-21 15:12:46 -08:00

We need to return the corresponding bit for a particular GPIO. This bit
contains shift not mask.

Signed-off-by: Markus Mayer <[email protected]>
Reviewed-by: Tim Kryger <[email protected]>
Reviewed-by: Matt Porter <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>

Commit: e2f0b00560729c47f39b2bc624eb93d82dc0e3e8
Parents: 2ba3154d

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/gpio/gpio-bcm-kona.c	modified	+1	−1	View file

drivers/gpio/gpio-bcm-kona.c

View file

diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index 72c927d..54c18c2 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -158,7 +158,7 @@ static int bcm_kona_gpio_get(struct gpio_chip *chip, unsigned gpio)
 	spin_unlock_irqrestore(&kona_gpio->lock, flags);
 
 	/* return the specified bit status */
-	return !!(val & bit);
+	return !!(val & BIT(bit));
 }
 
 static int bcm_kona_gpio_direction_input(struct gpio_chip *chip, unsigned gpio)