SUNRPC: Fix use of static variable in rpcb_getport_async

ec0dd267 · Ben Greear <[email protected]> · 2011-07-12 10:27:55 -07:00

Because struct rpcbind_args *map was declared static, if two
threads entered this method at the same time, the values
assigned to map could be sent two two differen tasks.
This could cause all sorts of problems, include use-after-free
and double-free of memory.

Fix this by removing the static declaration so that the map
pointer is on the stack.

Signed-off-by: Ben Greear <[email protected]>
Cc: [email protected]
Signed-off-by: Trond Myklebust <[email protected]>

Commit: ec0dd267bf7d08cb30e321e45a75fd40edd7e528
Parents: e5012d1f

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
net/sunrpc/rpcb_clnt.c	modified	+1	−1	View file

net/sunrpc/rpcb_clnt.c

View file

diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index 9a80a92..e45d2fb 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -597,7 +597,7 @@ void rpcb_getport_async(struct rpc_task *task)
 	u32 bind_version;
 	struct rpc_xprt *xprt;
 	struct rpc_clnt	*rpcb_clnt;
-	static struct rpcbind_args *map;
+	struct rpcbind_args *map;
 	struct rpc_task	*child;
 	struct sockaddr_storage addr;
 	struct sockaddr *sap = (struct sockaddr *)&addr;