fbcon: fix race condition between console lock and cursor timer

ec5da7f8 · Dave Airlie <[email protected]> · 2012-08-21 16:40:07 +10:00

So we've had a fair few reports of fbcon handover breakage between
efi/vesafb and i915 surface recently, so I dedicated a couple of
days to finding the problem.

Essentially the last thing we saw was the conflicting framebuffer
message and that was all.

So after much tracing with direct netconsole writes (printks
under console_lock not so useful), I think I found the race.

  Thread A (driver load)    Thread B (timer thread)
    unbind_con_driver ->              |
    bind_con_driver ->                |
    vc->vc_sw->con_deinit ->          |
    fbcon_deinit ->                   |
    console_lock()                    |
        |                             |
        |                       fbcon_flashcursor timer fires
        |                       console_lock() <- blocked for A
        |
        |
  fbcon_del_cursor_timer ->
    del_timer_sync
    (BOOM)

Of course because all of this is under the console lock,
we never see anything, also since we also just unbound the active
console guess what we never see anything.

Hopefully this fixes the problem for anyone seeing vesafb->kms
driver handoff.

Signed-off-by: David Airlie <[email protected]>
Acked-by: Alan Cox <[email protected]>
Cc: [email protected]
Tested-by: Josh Boyer <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

Commit

ec5da7f8dc023fc4dcbdd42e87dad231d2c2812d

Parents

9160338d

Changes

1 files changed · +5 −1