clk:at91: Fix memory leak in of_at91_clk_master_setup()

f63fcc90 · Masanari Iida <[email protected]> · 2014-02-11 22:15:07 +09:00

cppcheck detected following error
[clk-master.c:245]: (error) Memory leak: characteristics

The original code forgot to free characteristics when
irq_of_parse_and_map() failed.

Signed-off-by: Masanari Iida <[email protected]>
Acked-by Boris BREZILLON <[email protected]>
Acked-by: Alexandre Belloni <[email protected]>
Signed-off-by: Mike Turquette <[email protected]>

Commit: f63fcc90a379a269a07a1111f5b7ba28ebcb1eb4
Parents: ec6deea1

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/clk/at91/clk-master.c	modified	+1	−1	View file

drivers/clk/at91/clk-master.c

View file

diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c
index bd313f7..c1af80b 100644
--- a/drivers/clk/at91/clk-master.c
+++ b/drivers/clk/at91/clk-master.c
@@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc,
 
 	irq = irq_of_parse_and_map(np, 0);
 	if (!irq)
-		return;
+		goto out_free_characteristics;
 
 	clk = at91_clk_register_master(pmc, irq, name, num_parents,
 				       parent_names, layout,