libata: fix error checking in in ata_parse_force_one()

f7cf69ae · Tejun Heo <[email protected]> · 2017-05-31 14:26:26 -04:00

ata_parse_force_one() was incorrectly comparing @p to @endp when it
should have been comparing @id.  The only consequence is that it may
end up using an invalid port number in "libata.force" module param
instead of rejecting it.

Signed-off-by: Tejun Heo <[email protected]>
Reported-by: Petru-Florin Mihancea <[email protected]>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=195785

Commit: f7cf69ae171592d133c69b9adaa5de7cfb6038ea
Parents: 3e4240da

Changes

1 files changed · +1 −1

File	Status	Add	Del	Content
drivers/ata/libata-core.c	modified	+1	−1	View file

drivers/ata/libata-core.c

View file

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 2d83b8c..e157a0e 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6800,7 +6800,7 @@ static int __init ata_parse_force_one(char **cur,
 	}
 
 	force_ent->port = simple_strtoul(id, &endp, 10);
-	if (p == endp || *endp != '\0') {
+	if (id == endp || *endp != '\0') {
 		*reason = "invalid port/link";
 		return -EINVAL;
 	}