projects/linux·commit f99ebf0a

init: properly placing noinline keyword

f99ebf0a · Rakib Mullick <[email protected]> · 2009-01-06 14:40:38 -08:00

checkpatch warns about 'static void noinline'.  It wants `static noinline
void'.

Both are permissible, but the kernel consistently uses `static inline' and
`static noinline', and consistency is good.  Hence let's keep the
checkpatch warning and fix up this code site.

[[email protected]: rewrote changelog]
Signed-off-by: Md.Rakib H. Mullick <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Commit
f99ebf0a86de13f77bc4ee349de96db9f2f67f2e
Parents
91f47662

Changes

1 files changed · +2 −2

FileStatusAddDelContent
init/main.cmodified+2−2View file

init/main.c

View file
diff --git a/init/main.c b/init/main.c
index cd168eb..90926da 100644
--- a/init/main.c
+++ b/init/main.c
@@ -447,7 +447,7 @@ static void __init setup_command_line(char *command_line)
* gcc-3.4 accidentally inlines this function, so use noinline.
*/
-static void noinline __init_refok rest_init(void)
+static noinline void __init_refok rest_init(void)
__releases(kernel_lock)
{
int pid;
@@ -786,7 +786,7 @@ static void run_init_process(char *init_filename)
/* This is a non __init function. Force it to be noinline otherwise gcc
* makes it inline to init() and it becomes part of init.text section
*/
-static int noinline init_post(void)
+static noinline int init_post(void)
{
free_initmem();
unlock_kernel();