fs/adfs: fix filename fixup handling for "/" and "//" names

fc722a04 · Russell King <[email protected]> · 2019-03-24 14:00:35 +00:00

Avoid translating "/" and "//" directory entry names to the special
"." and ".." names by instead converting the first character to "^".

Acked-by: Al Viro <[email protected]>
Signed-off-by: Russell King <[email protected]>

Commit: fc722a0429f4e8a316e1992dcff6c78f45a25158
Parents: 5f8de487

Changes

1 files changed · +11 −4

File	Status	Add	Del	Content
fs/adfs/dir.c	modified	+11	−4	View file

fs/adfs/dir.c

View file

diff --git a/fs/adfs/dir.c b/fs/adfs/dir.c
index 51ed80f..fe39310 100644
--- a/fs/adfs/dir.c
+++ b/fs/adfs/dir.c
@@ -18,18 +18,25 @@ static DEFINE_RWLOCK(adfs_dir_lock);
 
 void adfs_object_fixup(struct adfs_dir *dir, struct object_info *obj)
 {
-	unsigned int i;
+	unsigned int dots, i;
 
 	/*
 	 * RISC OS allows the use of '/' in directory entry names, so we need
 	 * to fix these up.  '/' is typically used for FAT compatibility to
 	 * represent '.', so do the same conversion here.  In any case, '.'
 	 * will never be in a RISC OS name since it is used as the pathname
-	 * separator.
+	 * separator.  Handle the case where we may generate a '.' or '..'
+	 * name, replacing the first character with '^' (the RISC OS "parent
+	 * directory" character.)
 	 */
-	for (i = 0; i < obj->name_len; i++)
-		if (obj->name[i] == '/')
+	for (i = dots = 0; i < obj->name_len; i++)
+		if (obj->name[i] == '/') {
 			obj->name[i] = '.';
+			dots++;
+		}
+
+	if (obj->name_len <= 2 && dots == obj->name_len)
+		obj->name[0] = '^';
 
 	obj->filetype = -1;
 