projects/linux·commit fd217f4d

[PATCH] fs: add a sanity check in d_free

fd217f4d · Arjan van de Ven <[email protected]> · 2008-10-21 06:47:33 -07:00

Hi Al,

remember that debug session we did at KS? You suggested this patch back
then....

From 7751eaf30474b8cbfaea64795805a17eab05ac53 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Tue, 16 Sep 2008 16:51:17 -0700
Subject: [PATCH] fs: add a sanity check in d_free

we're seeing some corruption in the dentry->d_alias list that
appears like a free of an entry still on the list; this patch
adds a WARN_ON() to catch this scenario, as suggested by Al Viro

Signed-off-by: Arjan van de Ven <[email protected]>
Commit
fd217f4d70172c526478f2bc76859e909fdfa674
Parents
08b9fe6b

Changes

1 files changed · +1 −0

FileStatusAddDelContent
fs/dcache.cmodified+1−0View file

fs/dcache.c

View file
diff --git a/fs/dcache.c b/fs/dcache.c
index 12eac83..a1d86c7 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -69,6 +69,7 @@ struct dentry_stat_t dentry_stat = {
static void __d_free(struct dentry *dentry)
{
+ WARN_ON(!list_empty(&dentry->d_alias));
if (dname_external(dentry))
kfree(dentry->d_name.name);
kmem_cache_free(dentry_cache, dentry);