projects/linux·commit fdf290fd

[PATCH] UEAGLE : cmv name bug (was cosmetic)

fdf290fd · matthieu castet <[email protected]> · 2006-01-18 07:39:27 +01:00

this patch correct a possible bug with cmv_name being static. If there
is 2 modems and the driver is scheduled when filling cmv_name this could
result with garbage in cmv_name. We allocate cmv_name on the stack but
with a small size in order to avoid that.

Signed-off-by: Matthieu CASTET <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Commit
fdf290fd6d6a17b40055359263ed6003e87cb89b
Parents
e40abaf6

Changes

1 files changed · +1 −1

FileStatusAddDelContent
drivers/usb/atm/ueagle-atm.cmodified+1−1View file

drivers/usb/atm/ueagle-atm.c

View file
diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c
index b0026ec..830d2c9 100644
--- a/drivers/usb/atm/ueagle-atm.c
+++ b/drivers/usb/atm/ueagle-atm.c
@@ -1013,7 +1013,7 @@ static int request_cmvs(struct uea_softc *sc,
int ret, size;
u8 *data;
char *file;
- static char cmv_name[256] = FW_DIR;
+ char cmv_name[FIRMWARE_NAME_MAX]; /* 30 bytes stack variable */
if (cmv_file[sc->modem_index] == NULL) {
if (UEA_CHIP_VERSION(sc) == ADI930)