| 1 | Patch-Source: https://github.com/open-telemetry/opentelemetry-cpp/pull/4574
|
| 2 | --
|
| 3 | From ac9b358898b17a8a7592998745a6bd7e1e267fca Mon Sep 17 00:00:00 2001
|
| 4 | From: Om Kulkarni <[email protected]>
|
| 5 | Date: Tue, 15 Sep 2026 20:22:54 +0530
|
| 6 | Subject: [PATCH 1/3] [SDK] Add missing cstdint include to predicate_factory.h
|
| 7 |
|
| 8 | predicate_factory.h uses uint8_t but does not include cstdint, relying
|
| 9 | on a transitive include pulled in elsewhere in the translation unit.
|
| 10 | Building this header on its own fails with newer standard library
|
| 11 | implementations that no longer provide that transitive include.
|
| 12 | ---
|
| 13 | CHANGELOG.md | 6 ++++++
|
| 14 | .../opentelemetry/sdk/metrics/view/predicate_factory.h | 1 +
|
| 15 | 2 files changed, 7 insertions(+)
|
| 16 |
|
| 17 | diff --git a/CHANGELOG.md b/CHANGELOG.md
|
| 18 | index 608d6079f7..a757dd8d60 100644
|
| 19 | |
| 20 | |
| 21 | @@ -18,6 +18,12 @@ Increment the:
|
| 22 | * [API] Remove regex from trace_state.h
|
| 23 | [#4570](https://github.com/open-telemetry/opentelemetry-cpp/pull/4570)
|
| 24 |
|
| 25 | +* [SDK] Add a missing `<cstdint>` include to `predicate_factory.h`, which
|
| 26 | + uses `uint8_t` without including the header that declares it. This relied
|
| 27 | + on a transitive include from elsewhere in the translation unit and failed
|
| 28 | + to compile standalone on newer standard library implementations.
|
| 29 | + [#0000](https://github.com/open-telemetry/opentelemetry-cpp/pull/0000)
|
| 30 | +
|
| 31 | ## [1.29.0] 2026-09-13
|
| 32 |
|
| 33 | * [RELEASE] Bump main branch to 1.29.0-dev (#4259)
|
| 34 | diff --git a/sdk/include/opentelemetry/sdk/metrics/view/predicate_factory.h b/sdk/include/opentelemetry/sdk/metrics/view/predicate_factory.h
|
| 35 | index ca7dd4b389..501b69ba93 100644
|
| 36 | |
| 37 | |
| 38 | @@ -3,6 +3,7 @@
|
| 39 |
|
| 40 | #pragma once
|
| 41 |
|
| 42 | +#include <cstdint>
|
| 43 | #include <memory>
|
| 44 |
|
| 45 | #include "opentelemetry/nostd/string_view.h"
|
| 46 |
|
| 47 | From 8f233af1f787f2b7bfb6c5e2c6ff8495de7a3c19 Mon Sep 17 00:00:00 2001
|
| 48 | From: Om Kulkarni <[email protected]>
|
| 49 | Date: Tue, 15 Sep 2026 20:24:05 +0530
|
| 50 | Subject: [PATCH 2/3] Update CHANGELOG entry with PR number
|
| 51 |
|
| 52 | ---
|
| 53 | CHANGELOG.md | 2 +-
|
| 54 | 1 file changed, 1 insertion(+), 1 deletion(-)
|
| 55 |
|
| 56 | diff --git a/CHANGELOG.md b/CHANGELOG.md
|
| 57 | index a757dd8d60..0e6cd71517 100644
|
| 58 | |
| 59 | |
| 60 | @@ -22,7 +22,7 @@ Increment the:
|
| 61 | uses `uint8_t` without including the header that declares it. This relied
|
| 62 | on a transitive include from elsewhere in the translation unit and failed
|
| 63 | to compile standalone on newer standard library implementations.
|
| 64 | - [#0000](https://github.com/open-telemetry/opentelemetry-cpp/pull/0000)
|
| 65 | + [#4574](https://github.com/open-telemetry/opentelemetry-cpp/pull/4574)
|
| 66 |
|
| 67 | ## [1.29.0] 2026-09-13
|
| 68 |
|
| 69 |
|
| 70 | From bf3bf9802d18b5949405e5c44b2ff41365a06e5f Mon Sep 17 00:00:00 2001
|
| 71 | From: Om Kulkarni <[email protected]>
|
| 72 | Date: Wed, 16 Sep 2026 19:10:40 +0530
|
| 73 | Subject: [PATCH 3/3] Retrigger CI (Windows vcpkg job appears to have hit an
|
| 74 | infra timeout, unrelated to this change)
|
| 75 |
|