| 1 | Contributions are solicited in particular to remedy the following issues: |
| 2 | |
| 3 | cpcihp: |
| 4 | |
| 5 | * Returned code from pci_hp_add_bridge() is not checked. |
| 6 | |
| 7 | cpqphp: |
| 8 | |
| 9 | * The driver spawns a kthread cpqhp_event_thread() which is woken by the |
| 10 | hardirq handler cpqhp_ctrl_intr(). Convert this to threaded IRQ handling. |
| 11 | The kthread is also woken from the timer pushbutton_helper_thread(), |
| 12 | convert it to call irq_wake_thread(). Use pciehp as a template. |
| 13 | |
| 14 | * A large portion of cpqphp_ctrl.c and cpqphp_pci.c concerns resource |
| 15 | management. Doesn't this duplicate functionality in the core? |
| 16 | |
| 17 | * Returned code from pci_hp_add_bridge() is not checked. |
| 18 | |
| 19 | ibmphp: |
| 20 | |
| 21 | * Implementations of hotplug_slot_ops callbacks such as get_adapter_present() |
| 22 | in ibmphp_core.c create a copy of the struct slot on the stack, then perform |
| 23 | the actual operation on that copy. Determine if this overhead is necessary, |
| 24 | delete it if not. The functions also perform a NULL pointer check on the |
| 25 | struct hotplug_slot, this seems superfluous. |
| 26 | |
| 27 | * Several functions access the pci_slot member in struct hotplug_slot even |
| 28 | though pci_hotplug.h declares it private. See get_max_bus_speed() for an |
| 29 | example. Either the pci_slot member should no longer be declared private |
| 30 | or ibmphp should store a pointer to its bus in struct slot. Probably the |
| 31 | former. |
| 32 | |
| 33 | * ibmphp_init_devno() takes a struct slot **, it could instead take a |
| 34 | struct slot *. |
| 35 | |
| 36 | * The return value of pci_hp_register() is not checked. |
| 37 | |
| 38 | * The various slot data structures are difficult to follow and need to be |
| 39 | simplified. A lot of functions are too large and too complex, they need |
| 40 | to be broken up into smaller, manageable pieces. Negative examples are |
| 41 | ebda_rsrc_controller() and configure_bridge(). |
| 42 | |
| 43 | * A large portion of ibmphp_res.c and ibmphp_pci.c concerns resource |
| 44 | management. Doesn't this duplicate functionality in the core? |
| 45 | |
| 46 | * Returned code from pci_hp_add_bridge() is not checked. |
| 47 | |
| 48 | shpchp: |
| 49 | |
| 50 | * The hardirq handler shpc_isr() queues events on a workqueue. It can be |
| 51 | simplified by converting it to threaded IRQ handling. Use pciehp as a |
| 52 | template. |